fix: expose boot data and stop caching the frontend page - #1484
Merged
Conversation
get_context returned the boot values flat, so the template's
{% for key in boot %} loop had nothing to iterate and window.csrf_token
was never set, breaking every write from the SPA.
cache = 1 is not a property Frappe reads, and www pages are cached by
default. cache_html keys on path and language with no per-user key, so
the rendered page was cached with one user's CSRF token and served to
everyone. Set no_cache = 1 instead.
Also drop the db.commit() from a GET render.
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_context returned the boot values flat, so the template's {% for key in boot %} loop had nothing to iterate and window.csrf_token was never set, breaking every write from the SPA.
cache = 1 is not a property Frappe reads, and www pages are cached by default. cache_html keys on path and language with no per-user key, so the rendered page was cached with one user's CSRF token and served to everyone. Set no_cache = 1 instead.
Also drop the db.commit() from a GET render.