Skip to content

fix(trade_in): validate trade-in serial number against active warehouse stock #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aakvatech merged 1 commit into from
Aug 15, 2026
+15 −1
Merged

fix(trade_in): validate trade-in serial number against active warehouse stock #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion av_tools/av_tools_hooks/trade_in.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def validate_trade_in_serial_no_and_batch(doc, method):
)
)
else:
serial_numbers = row.custom_trade_in_serial_no.split("\n")
serial_numbers = [s.strip() for s in row.custom_trade_in_serial_no.split("\n") if s.strip()]
if len(serial_numbers) != row.custom_trade_in_qty:
error_messages.append(
_(
Expand All @@ -52,6 +52,20 @@ def validate_trade_in_serial_no_and_batch(doc, method):
row.idx,
)
)
else:
for sn in serial_numbers:
existing_sn = frappe.db.get_value(
"Serial No", sn, ["name", "warehouse", "status"], as_dict=True
)
if existing_sn and (
existing_sn.get("warehouse") or existing_sn.get("status") == "Active"
):
wh = existing_sn.get("warehouse") or "Active Stock"
error_messages.append(
_(
"<b>Row {0} ({1}):</b> Serial No <code><b>{2}</b></code> is already present in warehouse stock (<b>{3}</b>)."
).format(row.idx, row.custom_trade_in_item, sn, wh)
)
if error_messages:
frappe.throw(
title=_("Validation Errors"),
Expand Down
Loading