fix(landms): split government share out of TCB bank on plot payments; report govt share as cumulative collected - #100
Open
LISACORNEL wants to merge 1 commit into
Conversation
…correct govt-share reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On every plot payment, the government's share is split off at the bank — it goes to a separate government account, and only the remainder reaches the receiving bank.
The books previously recorded the full payment into the receiving bank, so:
What
Payment JE —
_post_government_share_jeDr Customer Advances / Cr Government Payable) plus a settlement (Dr Government Payable / Cr Bank) that removes the government share from the receiving bank, so the book balance reflects only the retained portion.Reports — government-payable report and executive dashboard
Cr Bankline is not double-counted.Not affected
Cash collected, deferred revenue, revenue recognized, gross margin, and all other figures are unchanged. Revenue recognized nets the completed-contract government share from a separate source, so there is no double-count.
Testing