fix(e2e): repair smoke drift from #1109 + neutralize ensure-default modal race (#1134)#1135
Open
vybe wants to merge 1 commit into
Open
fix(e2e): repair smoke drift from #1109 + neutralize ensure-default modal race (#1134)#1135vybe wants to merge 1 commit into
vybe wants to merge 1 commit into
Conversation
…odal race (#1134) frontend-e2e has been red on dev since 2026-06-10 (first on the #1114 run), unnoticed because the workflow is ui-label-gated. - smoke.spec.js: /operating-room now redirects to /operations (#1109); the old text assertions match nothing on the new page. Assert the redirect URL + Operations heading + tab strip instead — the test now also covers the legacy redirect. - api-keys-copy.spec.js: McpKeysTab onMounted fires ensure-default, which auto-creates 'Default MCP Key' and opens the key-ready modal at an arbitrary point mid-test, intercepting the Create click (both modals are fixed z-10 inset-0; later DOM node wins). beforeEach now calls ensure-default via API and reloads, making the page's own call a guaranteed no-op — the auto-modal can never appear mid-test, and the clipboard assertions always run against the test's own key modal rather than green-washing on the auto-modal. Fixes #1134 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vybe
added
type-bug
|
Resolve by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend-e2ehas been silently red on dev since 2026-06-10 — first failure on the #1114 run, before #1133 existed — because the workflow only runs onui-labelled PRs and recent UI PRs merged without the label. Two pre-existing test issues, both test-only fixes:1.
smoke.spec.js— operating room (assertion drift from #1109)/operating-roomredirects to/operationssince #1109; the page's visible text (heading Operations, tabs, "All clear…") matches none of the old/operating|queue|priority|all types|no items/patterns. The redirect itself works fine — verified via run artifacts. New assertions: redirect URL + Operations heading +Needs Responsetab, so the test now also covers the legacy redirect.2.
api-keys-copy.spec.js— ensure-default modal raceMcpKeysTab.vueonMountedfiresPOST /api/mcp/keys/ensure-default; with no user-scoped key present it auto-creates Default MCP Key and opens the "Your MCP API Key is Ready!" modal at an arbitrary point mid-test. Both that modal and the test's Create modal arefixed z-10 inset-0, so the later DOM node (auto-modal) intercepts the Create click for the full 30s budget — run-artifact screenshot shows the auto-modal covering the form.beforeEachnow callsensure-defaultviapage.requestand reloads, making the remounted page's own call a guaranteed no-op. Bonus: test 1's clipboard assertions previously could pass against the auto modal (same buttons, format-only checks); they now always exercise the test's own key modal.Verification
uilabel, sofrontend-e2eruns here and must be green to merge.Unblocks #1133 (which re-runs e2e on top of this fix).
Fixes #1134
🤖 Generated with Claude Code