Skip to content

Conversation

@yruslan
Copy link
Collaborator

@yruslan yruslan commented Jan 28, 2026

Closes #703

Summary by CodeRabbit

  • Configuration Changes

    • Clarified backfill window wording and options; default backfill.days changed to -1 to preserve prior behavior while simplifying guidance.
  • Improvements

    • Elevated retry failure log severity for better visibility.
    • Suppressed noisy evaluation-expression logging in scheduling and orchestration to streamline logs and surface actionable messages.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

Updated reference configuration to change default backfill.days to -1 and consolidated backfill documentation. Suppressed logging of evaluated infoDate expressions by passing logExpression = false at call sites. Increased two retry log messages from WARN to ERROR. Updated a unit test default accordingly.

Changes

Cohort / File(s) Summary
Configuration defaults
pramen/core/src/main/resources/reference.conf
Changed default backfill.days from 5 to -1; consolidated "Backfill window" documentation, removed guidance tying backfill behavior to track.days, and made minor phrasing/capitalization edits.
Logging level changes
pramen/core/src/main/scala/za/co/absa/pramen/core/utils/AlgorithmUtils.scala
Increased two retry-related log messages from WARN to ERROR in actionWithRetry.
Info-date evaluation logging
pramen/core/src/main/scala/za/co/absa/pramen/core/runner/orchestrator/OrchestratorImpl.scala, pramen/core/src/main/scala/za/co/absa/pramen/core/runner/splitter/ScheduleStrategyUtils.scala
Calls to evaluateRunDate(...) updated to evaluateRunDate(..., logExpression = false) to suppress logging of the evaluated expression; behavior and return values unchanged.
Tests
pramen/core/src/test/scala/za/co/absa/pramen/core/app/config/InfoDateConfigSuite.scala
Updated test expectation for default backfill.days from 5 to -1.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through configs, nudged backfill to -1,
Quieted the date whispers so logs won't run,
Turned two soft warns into errors that sing,
Tests took a small hop and now all's reckoned in.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes changes to logging levels in AlgorithmUtils and ScheduleStrategyUtils that appear unrelated to the backfill.days default value fix described in issue #703. Remove or justify logging-level changes (WARN to ERROR, logExpression = false additions) as they are outside the scope of fixing the backfill.days default behavior.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: setting the default backfill.days to -1 to restore compatibility with previous scheduling behavior, which is reflected across all modified files.
Linked Issues check ✅ Passed The PR fully addresses issue #703 by changing the default backfill.days from 5 to -1, updating configuration documentation, and updating corresponding tests to reflect this change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

… schedule strategy.

This is redundant and confusing.
@yruslan yruslan force-pushed the bugfix/703-fix-backfill-default-bahavior branch from 4e4a572 to 59dc844 Compare January 28, 2026 14:33
@github-actions
Copy link

Unit Test Coverage

Overall Project 84.1% 🍏
Files changed 100% 🍏

Module Coverage
pramen:core Jacoco Report 86.04% 🍏
Files
Module File Coverage
pramen:core Jacoco Report ScheduleStrategyUtils.scala 96.03% 🍏
OrchestratorImpl.scala 94.38% 🍏
AlgorithmUtils.scala 91.59% 🍏

@yruslan yruslan merged commit 916f094 into main Jan 29, 2026
7 checks passed
@yruslan yruslan deleted the bugfix/703-fix-backfill-default-bahavior branch January 29, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The deafult backfill.days behavior is not compatible with teh old behavior

2 participants