api: IBA::make_texture now honors "maketx:threads" hint #5014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
force-pushed
the
lg-mktexthread
branch
from
97bf90d to
0440528
Compare
Nearly all IBA functions take an optional nthreads parameter. But make_texture() did not, so there was no way to control its thread usage (it would always use the default number of threads). Without changing the call signature or ABI, this patch merely makes make_texture honor any "maketx:threads" hint passed in the config ImageSpec. Then this value is passed to the IBA functions, use of parallel_image, and anything else in the implementation of make_texture that would end up using the thread pool. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
force-pushed
the
lg-mktexthread
branch
from
0440528 to
05afc80
Compare
jessey-git
reviewed
Jan 28, 2026
jessey-git
approved these changes
Jan 28, 2026
Contributor
jessey-git
left a comment
jessey-git
left a comment
There was a problem hiding this comment.
Looks alright to me now. Watch out for the clang-format error though.
lgritz
force-pushed
the
lg-mktexthread
branch
from
68a2803 to
1c42dea
Compare
lgritz
merged commit bdb4208
into
AcademySoftwareFoundation:main
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly all IBA functions take an optional parameter controlling the threading. But make_texture() did not, so there was no way to control its thread usage (it would always use the default number of threads).
Without changing the call signature or ABI, this patch merely makes make_texture honor any "maketx:threads" hint passed in the config ImageSpec that it already takes to convey all sorts of controls over the texture creation process. Then this value is passed to any IBA functions, use of parallel_image, and anything else in the implementation of make_texture that would end up using the thread pool.
Fixes #4254