Skip to content

fix(IBA): reorient() cases for transpose and transverse #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luna-y-kim wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Draft

fix(IBA): reorient() cases for transpose and transverse #5350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/doc/stdmetadata.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ Display hints
3 rotated :math:`180^\circ` (bottom to top, right to left)
4 flipped vertically (bottom to top, left to right)
5 transposed (left to right, top to bottom)
6 rotated :math:`90^\circ` clockwise (right to left, top to bottom)
6 rotated :math:`90^\circ` counter-clockwise (right to left, top to bottom)

@lgritz lgritz Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this description is correct?

If this is default orientation 1:

    0--->
    1--->
    2--->

and this is orientation 6, rows right to left and columns top to bottom:

   2 1 0
   | | |
   v v v

Wouldn't you say that the second pattern is rotated clockwise from the default?

7 transverse (right to left, bottom to top)
8 rotated :math:`90^\circ` counter-clockwise (left to right, bottom to top)
8 rotated :math:`90^\circ` clockwise (left to right, bottom to top)
=== ==========================================================================

.. option:: "PixelAspectRatio" : float
Expand Down
4 changes: 2 additions & 2 deletions src/libOpenImageIO/imagebufalgo_orient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,15 +362,15 @@ ImageBufAlgo::reorient(ImageBuf& dst, const ImageBuf& src, int nthreads)
case 3: ok = ImageBufAlgo::rotate180(dst, src, ROI(), nthreads); break;
case 4: ok = ImageBufAlgo::flip(dst, src, ROI(), nthreads); break;
case 5:
ok = ImageBufAlgo::rotate270(tmp, src, ROI(), nthreads);
ok = ImageBufAlgo::rotate90(tmp, src, ROI(), nthreads);
if (ok)
ok = ImageBufAlgo::flop(dst, tmp, ROI(), nthreads);
else
dst.errorfmt("{}", tmp.geterror());
break;
case 6: ok = ImageBufAlgo::rotate90(dst, src, ROI(), nthreads); break;
case 7:
ok = ImageBufAlgo::flip(tmp, src, ROI(), nthreads);
ok = ImageBufAlgo::flop(tmp, src, ROI(), nthreads);
if (ok)
ok = ImageBufAlgo::rotate90(dst, tmp, ROI(), nthreads);
else
Expand Down
Loading