Skip to content

Autodetect modules#27

Closed
ErikBjare wants to merge 6 commits into
masterfrom
dev/autodetect-modules
Closed

Autodetect modules#27
ErikBjare wants to merge 6 commits into
masterfrom
dev/autodetect-modules

Conversation

@ErikBjare

@ErikBjare ErikBjare commented Aug 30, 2017

Copy link
Copy Markdown
Member

This is a nice one.

  • Detects modules in the users PATH (executables must contain "aw-")
  • Detects modules bundled with aw-qt (in the same directory)

This makes it a lot easier to run manage whichever module/watcher you want with aw-qt.

@ErikBjare

Copy link
Copy Markdown
Member Author

I'm probably going to go ahead and merge this when the macOS build is done.

@ErikBjare

ErikBjare commented Sep 1, 2017

Copy link
Copy Markdown
Member Author

I just realized that PyInstaller might mess up when you try to run system modules since it modifies LD_LIBRARY_PATH either directly or indirectly (since its likely to search the working directory).

  • Check that it handles system modules properly

@ErikBjare

Copy link
Copy Markdown
Member Author
  • Also, should probably test this on Windows where things might behave differently.

Comment thread aw_qt/manager.py


def _discover_modules_system() -> List[str]:
search_paths = os.environ["PATH"].split(":")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PATH might not be defined on Windows

@sanderboom

Copy link
Copy Markdown

This would be a sweet addition!

I'm probably going to go ahead and merge this when the macOS build is done.

And it was almost done? What's the holdup? Should I test under Window$?

@ErikBjare

Copy link
Copy Markdown
Member Author

Yeah testing on Windows (and macOS, but should be fine) is the blocker.

@ErikBjare

Copy link
Copy Markdown
Member Author

Closing in favor of #56

@ErikBjare ErikBjare closed this Apr 19, 2020
vasuemme111 pushed a commit to Ralvie-AI/aw-qt that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants