Skip to content

fix(ci): use 'poetry run' in test target + run typecheck #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Jun 24, 2026
Merged

fix(ci): use 'poetry run' in test target + run typecheck #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ aw_watcher_window/aw-watcher-window-macos: aw_watcher_window/macos.swift
swiftc $^ -o $@

test:
aw-watcher-window --help
poetry run aw-watcher-window --help # Ensures that it at least starts
make typecheck

@greptile-apps greptile-apps Bot Jun 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Using a bare make subprocess here works but loses any flags passed to the parent invocation (e.g., -j, --dry-run, or custom MAKEFLAGS). The idiomatic way to recurse into make is $(MAKE), which forwards the parent's flags automatically. The existing build target has the same pattern, so this is consistent — but worth fixing in both places if CI options ever expand.

Suggested change
make typecheck
$(MAKE) typecheck


typecheck:
poetry run mypy aw_watcher_window/ --ignore-missing-imports
Expand Down
Loading