fix(categories): allocate safe numeric ID when class list is empty

[TimeToBuildBob]

Problem

Closes #427.

After deleting all categories, clicking Add category creates a category with id: null that cannot be edited until after saving and reopening.

Root cause: addClass computes the next ID as:

new_class.id = _.max(_.map(this.classes, 'id')) + 1;

When this.classes is empty, _.max([]) is undefined, so undefined + 1 = NaN. JSON.stringify(NaN) produces null, matching the reported persisted object.

The same pattern was repeated in updateClass (the missing-ID fallback branch) and in three UI callers that re-derived the ID from _.max(...) after calling addClass.

Fix

Add a nextClassId() helper that handles the empty-array case:

function nextClassId(classes: Category[]): number {
  return (_.max(classes.map(c => c.id ?? -1)) ?? -1) + 1;
}

This returns 0 for an empty list and max + 1 otherwise.

• Use it in addClass() and the missing-ID branch of updateClass().
• Have addClass() return the assigned ID so UI callers don't need to recompute it.
• Update CategoryEditTree, CategorizationSettings, and CategoryBuilder to use the returned ID directly (removes the stale _.max(...) call from all three).

Tests

Two new regression tests in test/unit/store/categories.test.node.ts:

1. addClass after clearAll assigns id 0, not NaN/null — reproduces the exact bug scenario and verifies the new category is immediately editable via updateClass.
2. addClass after partial deletion starts from max existing id — verifies the max + 1 path still works correctly.

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.63%. Comparing base (9e466c5) to head (0d8d771).

Files with missing lines	Patch %	Lines
src/stores/categories.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   38.42%   38.63%   +0.20%     
==========================================
  Files          42       42              
  Lines        2225     2226       +1     
  Branches      441      443       +2     
==========================================
+ Hits          855      860       +5     
+ Misses       1292     1288       -4     
  Partials       78       78              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Greptile Summary

This PR fixes a bug where adding a category after clearing all categories produced one with id: null (via NaN) that couldn't be edited until after a save/reload cycle. The root cause was _.max([]) → undefined, making undefined + 1 = NaN, which JSON.stringify serialises as null.

• categories.ts: Both addClass and the missing-ID fallback in updateClass now guard with ?? -1, yielding 0 for empty lists. addClass returns the assigned ID so callers don't need to recompute it.
• Three UI callers (CategoryEditTree, CategorizationSettings, CategoryBuilder) are updated to use the returned ID directly, removing their stale _.max(_.map(...)) re-derivations. The now-unused lodash import is also cleaned up from CategorizationSettings.
• Two regression tests cover the exact bug scenario (empty list → id 0) and the max + 1 path after partial deletion.

Confidence Score: 5/5

Safe to merge — the change is a targeted, well-tested fix with no behavioural regressions in existing paths.

The fix correctly addresses the root cause in both addClass and updateClass, eliminates the stale re-derivation in all three callers, and is covered by two focused regression tests. No existing behaviour changes; the lodash import cleanup is also verified safe.

No files require special attention.

Important Files Changed

Filename	Overview
src/stores/categories.ts	Core fix: both addClass and updateClass now use ?? -1 to handle _.max([]) → undefined, returning 0 for empty lists. addClass now returns the assigned ID.
src/components/CategoryEditTree.vue	Removes the stale _.max(_.map(...)) re-derivation after addClass; uses the returned ID directly. Lodash import retained (still used by totalChildren).
src/views/settings/CategorizationSettings.vue	Same stale-ID re-derivation removed; lodash import correctly dropped since no other _ usage remains in this file.
src/views/settings/CategoryBuilder.vue	Uses returned ID from addClass instead of re-computing. Lodash import kept — still used by _.filter, _.escapeRegExp, and others.
test/unit/store/categories.test.node.ts	Two regression tests added: one reproducing the exact bug (empty list → id 0), one verifying max + 1 behaviour after partial deletion. Both are well-targeted.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant UI as UI Caller
    participant Store as categories store
    participant State as classes[]

    Note over UI,State: Before fix — empty list path
    UI->>Store: "addClass({ name, rule })"
    Store->>State: _.max([]) → undefined
    State-->>Store: "undefined + 1 = NaN"
    Store->>State: "push({ id: NaN })"
    Note over Store: JSON.stringify(NaN) = null
    Store-->>UI: (void) — caller re-runs _.max(...)
    UI->>Store: "updateClass({ id: null })"
    Note over UI: Edit broken until save+reload

    Note over UI,State: After fix — empty list path
    UI->>Store: "addClass({ name, rule })"
    Store->>State: "(_.max([]) ?? -1) + 1 = 0"
    State-->>Store: "id = 0"
    Store->>State: "push({ id: 0 })"
    Store-->>UI: returns 0
    UI->>Store: "updateClass({ id: 0, ... })"
    Note over UI: Category immediately editable

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant UI as UI Caller
    participant Store as categories store
    participant State as classes[]

    Note over UI,State: Before fix — empty list path
    UI->>Store: "addClass({ name, rule })"
    Store->>State: _.max([]) → undefined
    State-->>Store: "undefined + 1 = NaN"
    Store->>State: "push({ id: NaN })"
    Note over Store: JSON.stringify(NaN) = null
    Store-->>UI: (void) — caller re-runs _.max(...)
    UI->>Store: "updateClass({ id: null })"
    Note over UI: Edit broken until save+reload

    Note over UI,State: After fix — empty list path
    UI->>Store: "addClass({ name, rule })"
    Store->>State: "(_.max([]) ?? -1) + 1 = 0"
    State-->>Store: "id = 0"
    Store->>State: "push({ id: 0 })"
    Store-->>UI: returns 0
    UI->>Store: "updateClass({ id: 0, ... })"
    Note over UI: Category immediately editable

Loading

_{Reviews (4): Last reviewed commit: "fix(categories): use addClass return val..." | Re-trigger Greptile}

[TimeToBuildBob]

@greptileai review

[TimeToBuildBob]

The lint failure (unused lodash import) has been resolved. All CI checks passing now.

[TimeToBuildBob]

✅ Ready to merge

• CI: All checks passing (Build, Lint, CodeQL, Tests, Greptile)
• Greptile Review: 5/5 confidence — "Safe to merge — the change is a minimal, targeted fix with direct regression tests for the exact failure scenario."

[TimeToBuildBob]

I recorded work for this monitoring item, but the worker finished before posting the thread update. The delivery guard caught the missing reply and is closing the loop now.

Evidence: commit: 436ed1f658 chore(journal): aw-webui#892 merge conflict resolved — rebased onto upstream/master

Session: 16925cf7-f711-55fb-8b1c-0a68d39aaba9

[TimeToBuildBob]

@greptileai review

[TimeToBuildBob]

Status Update

Merge conflict resolved — rebased onto upstream/master (ActivityWatch/aw-webui) and force-pushed. The PR now has 1 file changed (the conflict was in CategorizationSettings.vue where the PR's approach—using addClass return value—correctly displaces the upstream _.max(...) pattern).

CI Status: ✅ All 8 checks passing (Analyze, Build vite/webpack, CodeQL, Test, lint)
Greptile: ✅ 5/5 confidence
Merge State: CLEAN + MERGEABLE

Ready for maintainer merge. (Bob does not have merge permissions on ActivityWatch/aw-webui, so handoff to maintainer.)

[TimeToBuildBob]

I recorded work for this monitoring item, but the worker finished before posting the thread update. The delivery guard caught the missing reply and is closing the loop now.

Evidence: commit: 8e07e0b84f chore(journal): monitoring cleanup for aw-webui PR #892

Session: 5a65d8f7-3279-56b7-ab38-91597e6c7803

[TimeToBuildBob]

@greptileai review