Merged
Conversation
…s and refactor selector validation logic
unbrokenclayman
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how backend view metadata is merged and enhances HTML validation for customization selectors. The most significant changes are the introduction of logic to merge duplicate backend views, the addition of comprehensive tests for this behavior, and expanded validation for selectors on non-field elements.
Backend Metadata Handling:
buildBackendViewMapinbackend-metadata-utils.tsto merge fields from duplicate backend views while preserving the first metadata instance. This ensures that all fields from aliased or duplicate views are included without overwriting the original view metadata.mergeBackendFieldshelper to merge fields from duplicate views into the canonical metadata instance.backendMetadata.test.tsto verify that duplicate views are merged correctly and that aliases point to the canonical metadata.HTML Validation Enhancements:
<qp-tab>), not just<field>, by generalizing the selector validation function. [1] [2] [3]htmlValidation.test.tsand a new fixture inSO301000_FieldSelectors.htmlto ensure diagnostics are produced when selectors on non-field elements reference missing targets. [1] [2]