Skip to content

JLN - Project Complete#37

Open
noglows wants to merge 38 commits intoAda-C4:jln/masterfrom
noglows:jln/master
Open

JLN - Project Complete#37
noglows wants to merge 38 commits intoAda-C4:jln/masterfrom
noglows:jln/master

Conversation

@noglows
Copy link
Copy Markdown

@noglows noglows commented Dec 4, 2015

Completed all requirements and styling.

100% Rspec test coverage.

noglows added 30 commits November 30, 2015 12:09
@noglows
Set up routes
0fe6d42
@noglows
Created controllers
154571b
@noglows
Generated models
3eaed4d
@noglows
Created seed data
a40f4d8
@noglows
Root route shows all media
f8bc680
@noglows
/movies page functional
96185c7
@noglows
Movie details page
6580143
@noglows
Created a partial for show
3778de5
@noglows
Created a partial for the index page
e87f17d
@noglows
Added model validation
a1a9828
@noglows
Added ability to delete movies
bac7ad0
@noglows
Can edit a movie
1ce0a3b
@noglows
Can vote for a movie
a7bd36e
@noglows
Can view all books, add books, edit books, delete books, and vote for…
f2b4ebb 
… books
@noglows
Everything working for albums
a9ec8e7
@noglows
Fixed a grammatical error
c41e10f
@noglows
Added limits to amount of content shown on root page
3638388
@noglows
Set up rspec files
75159ea
@noglows
Wrote some more specs
10206ea
@noglows
Created a new model method
8a5dadb
@noglows
Fixed some partials
1f3268a
@noglows
Partial fixes and form change
764f5bd
@noglows
Create bug fix
4c78ba4
@noglows
Added more rspec tests and added simplecov to gemfile
1522a59
@noglows
Specs added for albums and movies
0a92188
@noglows
Added polymorphic path to upvote
e0d89bb
@noglows
100% test coverage achieved
16fd820
@noglows
Fixed a bug where votes gets reset everytime there is an edit
e27c9f4
@noglows
Initial Bootstrap set-up
ecdea13
@noglows
Page title correctly styled
ee47433
@brittinator brittinator self-assigned this Dec 22, 2015
brittinator
brittinator reviewed Dec 22, 2015
View reviewed changes
config/routes.rb
Copy link
Copy Markdown

@brittinator brittinator Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of resources, you really did use all of them!

@brittinator
Copy link
Copy Markdown

brittinator commented Dec 22, 2015

Nice job! A couple last notes:

  • Your code between controllers is very consistent and makes it easy to follow - I like it.
  • I'm confused why you have _form, _index, _show and index all in 2 locations - application and shared. Are you using both versions of these?
  • I would add /coverage to your .gitignore. That way the huge files that change every time you run spec won't be tracked.
    I like your use of case in your shared example specs. Well done getting 100% coverage, that's something to celebrate for sure. 💯

brittinator
brittinator reviewed Dec 22, 2015
View reviewed changes
db/seeds.rb
Copy link
Copy Markdown

@brittinator brittinator Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see the movie? I thought it was decent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brittinator brittinator

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noglows @brittinator