Team Quartzy- Annalee, Meighan, Riley, Audrey

[Dreedle]

App deployed on Heroku:
http://quartzy.herokuapp.com/

Completed primary requirements.
92.6% rspec coverage
Code could be much dryer and neater in some areas, but we feel we accomplished a lot of work.

[QuartzBrandi]

I believe this @cart_status is not the same @cart_status in your orders_controller. Specifically this is an instance variable for the RSpec test, so it will be nil forever until it is assigned in the above let block.

[acmei]

Congrats on completing the Betsy project! The app works wonderfully and you all obviously have a good grasp on complicated logic in rails. Here are some things I noticed overall that could use some improvement:

• Naming: Try not to use letters as variables. It's always best to be descriptive when assigning names to data or functions so that your logic is clearer.
• Unused Code: There were lots of comments or even functions left in that seemed to go unused. Before making a PR, look over your files to remove these lines or files.
• Code Style: Indentation and spacing was kinda weird. Make sure functions are separated by a blank line, logic of the function is contained below the function name and indented (and even separated out into function paragraphs if the logic is complicated), html children are nested beneath parents, etc. I'd recommend looking up a ruby style guide and reading through. ALSO double check to make sure your text editor is set to spaces rather than tabs.
• Bangs (:exclamation:): There were lotsa bangs, and sometimes they were completely unnecessary. Always go for the simpler solution!!!!!!!!!!!!!!!!!!!!! See what I did there?
• Make sure your function or logic is contained in the correct file. If the function is helping to render something in the view, make it a helper method. If it's logic is affecting the object itself, put it in the model. This can be really confusing. Just keep at it and it'll make more sense if it doesn't already.

CODE ON! ⭐ ✌️

[QuartzBrandi]

I don't think you need to create all these users, categories, and products to test if the index page renders. In any case, what would happen if, say, there were no products to display?

EDIT: Looking at your welcome controller, I see why you needed to create all these. Still might be good to have logic that allows for edge cases like no products to display.

[ktrops]

Again, it's better to use full variable names instead of letters.