Admin user can merge two articles from edit page#25
Open
emgord wants to merge 34 commits intoAda-C4:masterfrom
Open
Admin user can merge two articles from edit page#25emgord wants to merge 34 commits intoAda-C4:masterfrom
emgord wants to merge 34 commits intoAda-C4:masterfrom
Conversation
… added to the view
| def merge | ||
| id = params[:id] | ||
| merge_id = params[:merge_with][:merge_id] | ||
| if current_user.admin? |
There was a problem hiding this comment.
Creating these local variables first is nice, but if the user isn't an admin, they aren't needed to i would suggest moving them into the first conditional
| end | ||
|
|
||
| def merge_with(other_article_id) | ||
| Article.find(other_article_id).comments.each do |comment| |
There was a problem hiding this comment.
There is a lot of method chaining going on here. Is there a better way to get the comments associated without iterating through each one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature allows admin to merge two articles from the edit page. Contributors do not have access to merge articles.