Open
Conversation
…ll need to set up initializer for each class.
…s to include a test to see if an instance can be created from a sample hash
…res all lib classes. Got rid of requiring far_mar in each class file. Not sure if that was the right move or not, seems functional for now tho.
Added CSV Hasher gem to far_mar.rb. fleshed out self.all and self.find(id) in farmar_market. Seems functional at the moment I think? Modified markets.csv to include a line of headers.
Added more farmar_market_spec tests. 100% coverage yay Need to fix file pathing for csv file in farmar_market. Rake is getting mad about the relative file pathing of the CSV. Not sure how to fix that yet, so just explicitily pathed file for now so I could move forward.
Still need to add tests for these new methods. Seems to work in IRB. Will need to change csv path once irb testing is done.
To work on tomorrow: -turning fixnum values into fixnums from csv -revenue method on vendor -date method on sales -refactoring code to include more enumerables -writing more tests -testing coverage -maybe try chronic gem ?
Tested methods to make sure they still worked! And they did!
Refactored self.all methods
For tomorrow - start with vendor_specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gems Required: csv_hasher
No optionals.
This project really helped me cement the concepts of testing and enumerables! So that's cool.
It'd be great to get feedback on my tests - are there too many? should I be testing different things? formatting them differently? etc.