Open
Conversation
… a searched letter;
…a given letter, refactored tests accordingly.
…d score method to total the points from the word;
…ord, and corresponding test.
…ble to preserve original orders of test arrays. Tested.
…ords_play), won?, and play methods. Corresponding tests.
…al_score method in Player class; Added comments showing method return values for clarity;
…Wrote tests for these methods.
…ted draw_tiles method to select a number of tiles from the array;
…instance of TileBag and puts them in a player_tiles array;
…e tiles are removed from the available letters. Fixed tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sophia Baldonado & Justine Winnie
No external dependencies
We did realize that we didn't write enough tests for the Player class- just ran out of time refactoring other things.
We were super pleased by the way we generated the array we used in TileBag - the code is commented out but we made the array with a hash, and it was very efficient.
We also learned through some very bizarre and unnerving test errors that one ought not to use constants in one's tests- or, at least not the way we were.