Open
Conversation
…e file. Then used Stack and Queues that we made in class to make it work
|
This looks really good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this to be very confusing. I first solved this by writing one class with methods that used the ruby methods pop and shift. I went back and solved this using the Stacks.rb and Queues.rb files that we created in class. I created a new class and initialized it so that I could check everything was working. The data at the bottom that is not commented out are my tests. I used constants so there are no magic numbers as well as trying to future proof so I can update this as a company size may change and I only have to change it there.