Completed Homework for Stacks and Queues #2
Open
jadevance wants to merge 2 commits intoAda-C5:masterfrom
Open
Conversation
| workers.push(waiting_workers.dequeue) | ||
| end | ||
|
|
||
| evil_boss_roulette = 1 + rand(6) |
There was a problem hiding this comment.
Nice! You're not even nice and let them get away with rolling a 0 and all being saved (You did it the way I intended, but not everyone will notice this nuance, I suspect.
|
Looks good -- Only comment I would make is that it would have been nice to have this code in methods so that we could cycle however we want and have the process repeat however we want. |
Author
|
After I wrote that solution I did think about how to move it into methods, but ran out of time to actually re-write it. Here's a quick pass: require_relative './Stack.rb' |
|
I like it!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.