Skip to content

Janice's Calculator#49

Open
janicewilson wants to merge 1 commit intoAda-C7:masterfrom
janicewilson:master
Open

Janice's Calculator#49
janicewilson wants to merge 1 commit intoAda-C7:masterfrom
janicewilson:master

Conversation

@janicewilson
Copy link
Copy Markdown

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? variables, arrays
How did you determine what operation to perform? via a self-defined method and case
Do you feel like you used consistent indentation throughout your code? yes
If you had more time, what would you have added to or changed about the program? I would have changed the error that Jou Jou found re calculating floats too early in the game. And adding a special case for division.

@kariabancroft
Copy link
Copy Markdown

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Done
Baseline
Readable code with consistent indentation. Well done

Summary

FYI, next time name the file in your pull request with .rb in the end of the filename. Otherwise it doesn't highlight Ruby syntax.

Your program seems to run twice, I'm not entirely sure why.

Nice work using the range to make sure the user enters a number, and nice work using an array to make sure it's a valid operation.

Reviewed by Chris

@janicewilson
Copy link
Copy Markdown
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants