Skip to content

Olivia_Stacks_Calculator.rb#50

Open
secretsharer wants to merge 7 commits intoAda-C7:masterfrom
secretsharer:master
Open

Olivia_Stacks_Calculator.rb#50
secretsharer wants to merge 7 commits intoAda-C7:masterfrom
secretsharer:master

Conversation

@secretsharer
Copy link
Copy Markdown

@secretsharer secretsharer commented Feb 11, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? Variables
How did you determine what operation to perform? By asking the user what they wanted to do.
Do you feel like you used consistent indentation throughout your code? Yes
If you had more time, what would you have added to or changed about the program? More functionality, continuing with the optional enhancements. Also, getting the check for erroneous input right. I've tried more things than I can remember and I still haven't gotten that part it to work. Yet.

@kariabancroft
Copy link
Copy Markdown

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Most of the code is there, but it's not working. See the summary below.
Baseline
Readable code with consistent indentation. Yes, well done here

Summary

Good work here. I would suggest that you use .downcase to make it easier to check the operator when you read in user input. On line 11 of your code I have a line: https://github.com/Ada-C7/ride-share which is causing the program to crash after reading in the 1st number. Also you have an error in your until loops to verify the user put in a number.

Reviewed by Chris

@CheezItMan
Copy link
Copy Markdown

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Check.
Baseline
Readable code with consistent indentation. Yes, well done here

Summary

Ok this works, thanks for resubmitting. Good work on the unless loops for making sure the user puts in valid input especially using the array to ensure the valid operator. The assignment did say you should take english-language input for the operators as well such as "add."

Reviewed by Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants