Queues - Tehut - MediaRanker

[tehut]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a model method on the works controller to calculate which of the works had the most votes. I called Work.all and iterated through to create a hash of work_id's and vote lengths and then used .max to find the first pair with the most votes.
Describe how you approached testing that model method. What edge cases did you come up with?	I did not test that method
Describe an edge case test you wrote for a controller	I didn't really do edge case testing. My tests are lacking on this assigment.
What are session and flash? What is the difference between them?	Both are hashes that hold information about user actions. A flash sends one-time messages to users based on their actions where a session holds information until the session is ended or until the user closes their browser.
Describe a controller filter you wrote.	We didn't get to this.
What was one thing that you gained more clarity on through this assignment?	I learned a lot about resources and routes as well as a bit (though not nearly enough) about fixtures.
What is the Heroku URL of your deployed application	https://tehutranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	None that didn't come up in retro! I learned a LOT on this assignment and really appreciate getting o do a large, challenging individual assignment immediately after paring. I was surprised to find out how much I knew and learned a lot during both Dan and Jamie's awesome live codes.

[tehut]

I didn't write a model method to evaluate vote totals but somehow most of my votes are recorded twice under the user though only once under the item itself.

If the cause behind this jumps out at you, I'd appreciate a hint on where I wrote that. I thought it was either something about how I set up my join or how I wrote my vote#create method but I couldn't really parse it.

[droberts-sea]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Semantic HTML	yes
Errors are reported to the user	While you do a good job of re-rendering the form, you don't include any information to let the user know what went wrong. I had to go read your model code to figure out why I couldn't add a movie.
Business logic lives in the models	yes - good work
Model testing	mostly - Looks like you made a good start on this for Work, especially around validations and relations. I would still like to see some tests for the category validation, as well as for your custom methods (as you mentioned in your PR).
Controller testing	yes - Looking primarily at WorksController here. You're missing a couple of cases we covered in class, particularly that any route taking an ID will return a 404 if the ID is invalid. However, it looks like you've got at least one instance of each type of test. Testing around user login and voting is OK to not have yet.
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes - I see you have a route for logout, but I don't see any links to do so on your site.
The ID of the current user is stored in the session	yes
Individual user pages and the user list are present	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	no
Splash page contains a media spotlight	yes
Media pages contain lists of voting users	yes
Wave 3 - Styling
Foundation is used appropriately	yes
Look and feel is similar to the original	yes - good work!
Overall

Excellent work! MediaRanker is a big project, and while your implementation has a few rough edges you clearly achieved the main functionality of the site. I look forward to seeing what you accomplish with bEtsy.