Queues - Sofia Kim - MediaRanker

[Sofia15]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer	Instructor Response
Describe a custom model method you wrote.	self.top under work model to get top 10 items of each media by foreign keys of intermediate model
Describe how you approached testing that model method. What edge cases did you come up with?	I think that the model method testing is about confirming validations and the database on model.	Nope, just like with regular ruby you have to test any custom methods your write.
Describe an edge case test you wrote for a controller	I wasn't sure to create edge cases.
What are session and flash? What is the difference between them?	both of them are rails hash like object that allows to persist ruby objects between HTTP requests without necessarily using the database. Flash persists for only one request so it can get a message displayed after it redirects.
Describe a controller filter you wrote.	N/A
What was one thing that you gained more clarity on through this assignment?	rails model
What is the Heroku URL of your deployed application	https://funranker.herokuapp.com
Do you have any recommendations on how we could improve this project for the next cohort?

[droberts-sea]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes - see instructor comments above
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Semantic HTML	yes
Errors are reported to the user	no - While you do a good job of re-rendering the form if the validations fail, the form doesn't have any way to inform the user of what went wrong. I had to go read your model code to figure out why I couldn't make a new work.
Business logic lives in the models	yes - good work
Model testing	You've made a good start here. For your tests on validations, I'd like to see two more things: first, check that the field you're interested in is what made the validation fail (should be included in errors.messages), and second, that you are able to create a work where all the validations pass. For your tests on the self methods, I like the tests you've got, but I would like to see you test what happens when there are no matches (no movies for Work.movies, for example).
Controller testing	yes - good work!
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes, using one of the seed users
The ID of the current user is stored in the session	yes
Individual user pages and the user list are present	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	the ones on the splash page are, but not on the category indices
Splash page contains a media spotlight	yes
Media pages contain lists of voting users	no
Wave 3 - Styling
Foundation is used appropriately	yes
Look and feel is similar to the original	Pretty close except for the buttons. Try adding a class: "button" argument in your link_to or button_to tags.
Overall

Good work overall! This project was quite big with many moving parts, and it seems like you've hit almost all of the learning goals. The vast majority of functionality is there, and your test coverage is even pretty good.

Things you should focus on during bEtsy:

• Really thinking through test coverage, especially for models. Ask yourself: what are all the things that could go wrong here? Feel free to come to Jamie or I if you have any questions or want to check that you've gotten everything.
• Error reporting - if there's ever a time that something could go wrong because of what the user typed in, you've got to let them know what happened and how they can fix the problem. See the instructor version of MediaRanker for good examples of this.