Queues - Andrea Valliere - MediaRanker

[avalliere]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	In the works model, I wrote a class method that retrieves all the work objects that have a given category. This method is used on the welcome index to sort the works by movies, albums, and books.
Describe how you approached testing that model method. What edge cases did you come up with?	I do not have tests written yet.
Describe an edge case test you wrote for a controller
What are session and flash? What is the difference between them?	Session stores a small amount of data during the endurance of the session. Flash is part of the session and is cleared with each request.
Describe a controller filter you wrote.	My sessions controller contains an if else statement in the create method to handle whether a new user is created or an existing user is logged in.
What was one thing that you gained more clarity on through this assignment?	Sessions and flash, general structure of a rails program and steps in the process of writing one. I am getting a better handle on creating a rails project with each assignment.
What is the Heroku URL of your deployed application	https://andrea-media-ranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	I would have liked some of the new tools and information used in this assignment to have been introduced in previous assignments. I'm glad to not have to learn all of them for betsy, but there was enough new material in this assignment that I didn't even get to try using tests. I think a more manageable project that I was capable of finishing might have made me feel more prepared for betsy.

[PilgrimMemoirs]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Mostly good - session definition should be expanded - what is the "endurance of the session"? We ended up not doing any controller filters in this project.
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML	Mostly good - some pages missing semantic sectioning tags around content, like in users index page and some of welcome index.
Errors are reported to the user	No errors shown - no validations
Business logic lives in the models	Well Done
Models are thoroughly tested, including relations, validations and any custom logic	Not Complete
Controllers are thoroughly tested	Some - Not complete
Wave 1 - Media
Splash page shows the three media categories	Well Done
Basic CRUD operations on media are present and functional	Can create and read - but not edit and delete.
Wave 2 - Users and Votes
Users can log in and log out	Well Done
The ID of the current user is stored in the session	Well Done
Individual user pages and the user list are present	Some - User list is present, not individual (show)
A user cannot vote for the same media more than once	Well Done
All media lists are ordered by vote count	Not Complete
Splash page contains a media spotlight	Not Complete
Media pages contain lists of voting users	Not Complete
Wave 3 - Styling
Foundation is used appropriately	Good start- missing parent class around each category list that has a class of row.
Look and feel is similar to the original	Well Done
Overall
	Any files not being used should be deleted - like the movies controller.
	There are some things missing that I want to see you work in in Betsy: Controller and model tests with edge case, show errors and flash messages to users in the browser, HTML is always using sectioning tags, Complete CRUD functionality on a resource, use foundation grid