Queues - Sahana Murthy - Static Site

[sahanamurthy]

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I had forgotten to close a tag. This was brought to my attention by the HTML validator.
Why is it important to consider and use semantic HTML?	So that you can section your HTML to be easily accessible by CSS selectors.
How did you decide to structure your CSS?	I implemented rule sets for different blocks as needed.
What was the most challenging piece of this assignment?	Finding content for 4 pages of HTML.
Describe one area that you gained more clarity on when completing this assignment	I gained more clarity on how headers, main sections, and footers interact with each other.

[droberts-sea]

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	I would still like to see more frequent commits, and more descriptive commit messages. As with Ruby you should commit every time you complete some work on a method, so with HTML you should commit every time you complete work on a part of a page.
Answered comprehension questions	yes
Page fully loads	yes
No broken links (regular or images)	yes
Includes at least 4 pages and styling	yes
HTML
Uses the high-level tags for organization: header, footer, main	yes
Appropriately using semantic tags: section, article, etc.	yes
All images include alternate text	N/A
CSS
Using class and ID names in style declarations	yes
Style declarations are DRY	Within the stylesheet for any one page the CSS is DRY, but between pages there's a lot of repetition. A common trick is to have one stylesheet for common content like the header and footer which is linked from every page, and separate files for page-specific content.
Overall

Great work overall. Site is attractive and easy to navigate, and HTML forms a clear tree structure. I especially like the way you've broken your CSS out into multiple files - that makes it easy to see what affects what.

[NatashaRaime]

Hello Sahana! I hope you are doing well. I'm sure this isn't strictly part of the review process, but allow me to say, hello!

req = request
nit = nit-picky
grat = gratitude/praise

grat: I really enjoyed looking at the final product and was impressed by your stylistic skill
req: perhaps there is a way to share one css sheet to style shared properties site-wide?
This would save time and keep your code trimmed down — preventing unwieldy file structure(s). If you are using HTML4, id’s and classes will help clearly define elements. If you are using HTML5, I believe this can be accomplished with ease.

grat: It is clear improvement developed with each commit, which is great (and, not always the case).
req: I do agree with Dan that perhaps more commits between inception and completion would be helpful*

aside: The reason I suggest this is, other than the safeguard it provides in terms of providing additional code-snapshots you can revert to if something goes horribly wrong**, but also that their collective presence demonstrates your ability 1. at the beginning of your work 2. to be self critical and digest criticism 3. to demonstrate meaningful improvement and if you leverage coding-weaknesses as opportunities for personal growth. All of which are extremely valuable as an employee in convincing those around you of your talent, ultimately translating to success!

Finally, HTML, very well done!
nit: I am curious why the index page ref is outside the nav.
req: In passions.html, are article tags the most appropriate for these elements?
grat: I like how you define mains, nav, header and footer areas of the page consistently!
nit: consider using a broad section element to denote cohesive elements, then nest smaller items within it as a piece of the broader section.

Overall, I really enjoyed the site. Your skills are impressively strong already, it was a bonus to get a general sense of your aesthetic preferences (and apparently florals and pineapples rank highly) and personality :)
Thanks!
-n

*an area I also struggled with
**and, it always does