Queues - Elizabeth Deutsch - Static-Site by edeutschie · Pull Request #18 · Ada-C7/Static-Site

edeutschie · 2017-03-20T06:10:06Z

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	It did catch some errors I was able to fix. Only thing we hadn't discussed was puting in the html file when using Lorem ipsum. Not sure if that is necessary.
Why is it important to consider and use semantic HTML?	It is easier to style, see mistakes to make corrections, and easier to go back and make changes later if semantic HTML is used. Also, the better the semantic HTML, the better the browser can understand how the programmer intends the website to be seen and translate it for the viewer/user.
How did you decide to structure your CSS?	I started with a main.css file and organized it with header, main, and footer sections. This was for the index page and for the elements the index page shared with all the other pages (the main header and nav bar for example). Then I had .css files for each additional page of the website with styling that was specific to them.
What was the most challenging piece of this assignment?	Positioning. I gravitated towards using floats, but that created a lot of problems for me if the browser was not set to full screen. I had to go back and rework many of my pages to display: inline-block instead.
Describe one area that you gained more clarity on when completing this assignment	Positioning. Same as above. I was much more used to using floats. In this assignment I learned how to use inline-block positioning better. Also, got more practice using percentages rather than pixels.

…ut html. clean up.

PilgrimMemoirs · 2017-03-30T20:46:42Z

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	❗️ Need to commit more often.
Answered comprehension questions	Well Done
Page fully loads	Well Done
No broken links (regular or images)	Well Done
Includes at least 4 pages and styling	Well Done
HTML
Uses the high-level tags for organization: `header, footer, main`	Well Done
Appropriately using semantic tags: `section, article`, etc.	Well Done
All images include alternate text	Well Done
CSS
Using class and ID names in style declarations	Well Done
Style declarations are DRY	Well Done - there was one ruleset that could have been mostly included with another one (#hero #two, #hero #three could have been combined with #hero #one - then #hero #two, #hero #three could have it's own ruleset for the one different style).
Overall
Portfolio	It looks really nice, though doesn't provide any info on the projects - some suggestions would be to have the title of the project show when hovering over the image. Or having the title on top of the image, with a short description below.
Organization	HTML and CSS is very well organized and easy to read! Great work!

morrime · 2017-04-04T04:58:51Z

Great work! Your use of semantic HTML is excellent, as is your organization of the HTML and CSS files. The site is visually pleasing and engaging. Make sure to keep working on committing early and often. Here's an article I've found helpful for writing strong commit messages. Also, nice job using percentages instead of pixels. You can avoid a lot of weird looking formatting for your users if you continue that practice.

morrime · 2017-04-04T04:15:42Z

+    <section id="hero">
+      <h1>Elizabeth Deutsch</h1>
+      <p>Elizabeth is a junior developer and Seattle native.</p>
+      <!-- <p>A current student at Ada Developer's Academy</p> -->


In future PRs or Code Reviews, feel free to delete any commented out/unused code.

morrime · 2017-04-04T04:16:40Z

+        <ul>
+          <li class="contents"><a href="https://github.com/Ada-C7/Word-Guess/pull/11"><img  src="assets/Ducks_Dark.png" alt="ASCII art of ducks"/></a></li>
+          <li class="contents"><a href="https://github.com/edeutschie/meowspace"><img class="img-circle" src="assets/cat.jpg" alt="cat photo"/></a></li>
+          <li class="contents"><a href="https://github.com/edeutschie/ride-share-two"><img src="assets/wheel.png" alt="photo of steering wheel"/>  </a> </li>


Excellent semantic HTML throughout the project!

morrime · 2017-04-04T04:21:44Z

+          </ul>
+        </nav>
+    </header>
+


Nice use of whitespace and proper indentation to help maintain readability.

morrime · 2017-04-04T04:30:32Z

+  height: 75px;
+}
+
+#portfolio img {


The styling you chose for the images is really nice!

morrime · 2017-04-04T04:32:40Z

+footer {
+  margin-top: 8%;
+  margin-bottom: 1%;
+}


You may want to consider centering the footers on each page.

morrime · 2017-04-04T04:44:19Z

+        <h1>Portfolio</h1>
+        <p>A sampling of recent projects at Ada Developer's Academy</p>
+        <ul>
+          <li class="contents"><a href="https://github.com/Ada-C7/Word-Guess/pull/11"><img  src="assets/Ducks_Dark.png" alt="ASCII art of ducks"/></a></li>


I agree with Jamie's comment about the titles. It would be cool to see a brief description of the link before clicking. Also, :hover is nice because it makes it obvious to people that the image is a link as well. You could change the border color, the image size, or have the title appear when hovering over an image.

morrime · 2017-04-04T04:46:28Z

@@ -0,0 +1,116 @@
+@import url('https://fonts.googleapis.com/css?family=Slabo+27px');


morrime · 2017-04-04T04:46:57Z

@@ -0,0 +1,116 @@
+@import url('https://fonts.googleapis.com/css?family=Slabo+27px');
+


Your organization of CSS files is great!

morrime · 2017-04-04T04:48:53Z

+  margin-left: 3%;
+}
+
+.emoji:hover::before {


I like the hover emoji you have here. It's makes it really clear that these are links, and it's cute.

morrime · 2017-04-04T04:50:45Z

+.contents a {
+  text-decoration: none;
+}
+


You may want to consider putting more space between the links, so when you hover over one, it doesn't displace the others with the emoji.

edeutschie added 5 commits March 17, 2017 20:55

started all files. html and css for index.html and main.css

392e625

basic html and css for portfolio plus some links and images

0ef9d14

added style pages for blog and about pages. wrote unique blog and abo…

2ee41a5

…ut html. clean up.

removed floats to improve alignment. Cleaned up code.

7e5e5a3

added images

5148da2

Hamled assigned morrime Mar 22, 2017

morrime reviewed Apr 4, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Queues - Elizabeth Deutsch - Static-Site#18

Queues - Elizabeth Deutsch - Static-Site#18
edeutschie wants to merge 5 commits intoAda-C7:masterfrom
edeutschie:master

edeutschie commented Mar 20, 2017

Uh oh!

PilgrimMemoirs commented Mar 30, 2017

Uh oh!

morrime commented Apr 4, 2017 •

edited

Loading

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

morrime Apr 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,116 @@
		@import url('https://fonts.googleapis.com/css?family=Slabo+27px');

Conversation

edeutschie commented Mar 20, 2017

Static Site

Comprehension Questions

Uh oh!

PilgrimMemoirs commented Mar 30, 2017

Static Site

What We're Looking For

Uh oh!

morrime commented Apr 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

morrime commented Apr 4, 2017 •

edited

Loading