Skip to content

Queues - Andrea Valliere - Static-Site#21

Open
avalliere wants to merge 29 commits intoAda-C7:masterfrom
avalliere:master
Open

Queues - Andrea Valliere - Static-Site#21
avalliere wants to merge 29 commits intoAda-C7:masterfrom
avalliere:master

Conversation

@avalliere
Copy link
Copy Markdown

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I neglected to give my index.html page a title. I resolved this after it came up in the HTML validator. Other issues seemed to be more style suggestions.
Why is it important to consider and use semantic HTML? Semantic HTML keeps code clearer and much easier to read. It is also easier to target selectors when you have an appropriate variety of tag types.
How did you decide to structure your CSS? I sectioned it by page, and generally tried go down the page in order with my CSS. I would like to learn more about preferred methods of organization.
What was the most challenging piece of this assignment? Anticipating the relation between other objects as you make changes, especially in regards to spacing.
Describe one area that you gained more clarity on when completing this assignment I am using padding and margin more easily, as well as the developer tools.

… elements. Removed placeholder image on index.html
@PilgrimMemoirs
Copy link
Copy Markdown

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Well Done
Answered comprehension questions Well Done
Page fully loads Well Done
No broken links (regular or images) Well Done
Includes at least 4 pages and styling Well Done
HTML
Uses the high-level tags for organization: header, footer, main Mostly Good - header & footers used appropriately. should be used to wrap around the pages's most relevant content, typically after header/before footer.
Appropriately using semantic tags: section, article, etc. Well Done
All images include alternate text ❗️ Does not have
CSS
Using class and ID names in style declarations Well Done
Style declarations are DRY Mostly Good - Some styles, like repeated colors and display types/floats, could be declared in one ruleset with multiple selectors.
Overall Looks great! The use of hover selector is being very cleverly used on portfolio page

Copy link
Copy Markdown

@mcarson1111 mcarson1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks great. I like the use of hover selector, and it is very well organized both in html tags and your css page. Its been a really long time since Ive used html or css as i took 6 months after class, so this might be obvious to others; it seems like in your div class "circle", you're not putting anything, you just open and then close it. Can you explain this a bit to me? it's done a lot, especially in code_journal.html ( line 38, 49, 60...) Again, I've been away from this for nearly a year so I'm a bit rusty.
All in all I think it looks great and Your organizational skills are on point. Well done. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants