Queues - Andrea Valliere - Static-Site#21
Open
avalliere wants to merge 29 commits intoAda-C7:masterfrom
Open
Conversation
…pdate aesthetically.
…oesn't run into header.
…with article elements on other pages
… elements. Removed placeholder image on index.html
Static SiteWhat We're Looking For
|
mcarson1111
reviewed
Apr 2, 2017
mcarson1111
left a comment
There was a problem hiding this comment.
Overall it looks great. I like the use of hover selector, and it is very well organized both in html tags and your css page. Its been a really long time since Ive used html or css as i took 6 months after class, so this might be obvious to others; it seems like in your div class "circle", you're not putting anything, you just open and then close it. Can you explain this a bit to me? it's done a lot, especially in code_journal.html ( line 38, 49, 60...) Again, I've been away from this for nearly a year so I'm a bit rusty.
All in all I think it looks great and Your organizational skills are on point. Well done. ^_^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions