Queues - Erica J. Case - Static-Site#24
Conversation
Static SiteWhat We're Looking For
|
lbueing
left a comment
lbueing
left a comment
There was a problem hiding this comment.
Hi Erica!
Overall, Great job! You'll notice that I added a lot of comments that are 'nit-picky'. Most of them are in regards to typos/spacing. While spacing doesn't affect the outcome of your code, it's a stylistic thing that will get noted in industry code reviews. Also, for many of the spacing instances, I only commented on the first or second time it happened, but you may want to scan your code to note where other occurrences are.
You did an excellent job of using semantic tagging. Your layout was neat and tidy, very easy to read. It's clear you put a lot of work into this!
| <h2 class="left">Ecologist</h2> | ||
| <ul class="left"> | ||
| <li class=>Plant community dynamics</li> | ||
| <li >Invasive species</li,> |
There was a problem hiding this comment.
line 33: nit - Extra space and comma after li's.
| </head> | ||
| <body> | ||
| <header> | ||
| <h2><i class="material-icons" style="font-size:36px">home</i></h2> |
There was a problem hiding this comment.
line 15: Best practice to keep as much of your styling in you css sheet.
| <title>Portfolio Project</title> | ||
| <link rel="styles/normalize.css" href="icono.min.css"> | ||
| <link rel="stylesheet" href="styles/main.css"> | ||
| <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet"> |
There was a problem hiding this comment.
line 8: nitpick - It's nice to have all your links in the same general format. rel then href on each
| <li>Rare species conservation</li> | ||
| </ul> | ||
| </div> | ||
| <i id = "recycle" class="fa fa-recycle"></i> |
There was a problem hiding this comment.
line37: What is this line for?
nit - id="recycle" remove extra spaces
| </ul> | ||
| </div> | ||
| <i id = "recycle" class="fa fa-recycle"></i> | ||
| <div, id="Programmer"> |
| <li >Invasive species</li,> | ||
| <li>Rare species conservation</li> | ||
| </ul> | ||
| </div> |
| <header> | ||
| <a href="index.html" class="home"> <i class="fa"></i></a></li> | ||
| <h1 class="erica">Erica Case: PROJECTS</h1> | ||
| <a href="projects.html" class="portfolio"> <i class="fa"></i></a></li> |
There was a problem hiding this comment.
line 14: nit - extra space after <a
line 14 and 16: nit - no space needed between the a tag and the i tag
|
|
||
| <footer> | ||
| <a href="blog.html" class="blog"> <i class="fa"></i></a></li> | ||
| <a href="me.html" class="me" > <i class="fa" ></i></a></li> |
There was a problem hiding this comment.
line 69-70: These font awesome things are really cool! Nice find!
| </main> | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
No need to leave more than one extra line in between.
| <h3>Ruby Code</h3> | ||
| <aside> | ||
| <h4>Development</h4> | ||
| <i class="fa"> </i> |
4 participants
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions