Queues - Hyunji Kim - Static-Site#27
Open
ricecakemonster wants to merge 21 commits intoAda-C7:masterfrom
Open
Conversation
Static SiteWhat We're Looking For
|
KellyPT
reviewed
Mar 31, 2017
KellyPT
left a comment
KellyPT
left a comment
There was a problem hiding this comment.
You have really strong git commits!
Lovely photos ❤️
I am truly amazed by your CSS work. I had to look up many of your syntax and selectors. (Maybe I should go back to ADA for a review?).
| </nav> | ||
| </span> | ||
| </header> | ||
|
|
There was a problem hiding this comment.
Awesome usage of <div> and <span> here in the <header> section. You know the difference well!
| <section id="hero"> | ||
| <img src="../images/mommy.jpg" class = "bounce-in-top" alt="hero image"> | ||
| <h1 class = "dropshadow">It's Me!</h1> | ||
| <p class="center-p"> |
There was a problem hiding this comment.
I'm a bit confused about this start.html and index.html. Which one is the homepage?
| <link href ="../styles/styles.css" rel="stylesheet"> | ||
| </head> | ||
| <body id="about"> | ||
| <main> |
There was a problem hiding this comment.
Really minor comment: A navigation bar at the top of each page would help me go back and forth between your website pages more easily. :)
| <link href ="../styles/styles.css" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <main> |
| <link href ="../styles/normalize.css" rel="stylesheet"> | ||
| <link href ="../styles/styles.css" rel="stylesheet"> | ||
| </head> | ||
| <body> |
| line-height: 1.15; /* 2 */ | ||
| -ms-text-size-adjust: 100%; /* 3 */ | ||
| -webkit-text-size-adjust: 100%; /* 3 */ | ||
| } |
| line-height: 0; | ||
| position: relative; | ||
| vertical-align: baseline; | ||
| } |
| [type="reset"], | ||
| [type="submit"] { | ||
| -webkit-appearance: button; /* 2 */ | ||
| } |
| [type="submit"]::-moz-focus-inner { | ||
| border-style: none; | ||
| padding: 0; | ||
| } |
| [type="reset"]:-moz-focusring, | ||
| [type="submit"]:-moz-focusring { | ||
| outline: 1px dotted ButtonText; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions