Regan's static site

[pancake-batfish]

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	It didn't like the Google Font convention in its link of separating different typefaces with an or sign, but I chose to leave it. I had a stray tag which it caught that I removed.
Why is it important to consider and use semantic HTML?	It's a tool for communicating your intent to other humans, and also aids computers in understanding the structure of your page for use in assistive tools for those unable to interact with the internet by mainstream means or for other purposes not yet imagined.
How did you decide to structure your CSS?	I grouped parts of the CSS based on the parts of the page they targeted. I began with CSS that applied to all the pages and then ended with CSS that just applied to the subpages, and might have followed that with styles just needed by a single page.
What was the most challenging piece of this assignment?	I find it hard to see why CSS isn't working. I know it is fundamentally no less logical than other tools, but it always feels to me like the logic is obscure and that the whole system just wants to make me crazy.
Describe one area that you gained more clarity on when completing this assignment	Ways of using Chrome DevTools to spot the source of visual issues.

[kariabancroft]

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Yes... though you're right on the verge with the frequency
Answered comprehension questions	Yes
Page fully loads	Yes
No broken links (regular or images)	Almost - your LinkedIn link is using a relative path rather than the absolute URL so it doesn't work
Includes at least 4 pages and styling	Yes. My first thought was maybe that something was broken with the Home image/link with relation to the rest, but it's hard for me to know if that was your intention :-p (maybe you can show me yours this week)
HTML
Uses the high-level tags for organization: header, footer, main	Yes
Appropriately using semantic tags: section, article, etc.	Yes
All images include alternate text	Yes
CSS
Using class and ID names in style declarations	Yes - Using classes for shared styles
Style declarations are DRY	Yes! Could you combine the .navbox and .navbox img?
Overall	Nice job adding the target attribute to open external links in a new tab. I noticed some images in git that you didn't end up using - I'd recommend cleaning these up if they're done used. Nice job overall

[jm-rives]

Looks good. Very cool site.

You'll never go wrong making your commits more granular. As the projects become more complex and you work in teams it will make merging code and debugging easier. To get myself in the habit of frequently committing I would make commit after each new empty object and each semantic change. If you will it is better to go back in time minute by minute than in 8 hour blocks.

Your indentation is good and your code is very readable. If you are doing this manually consider using a linter or the Atom Beautify package to save yourself some time.

I liked your logic behind your CSS structure. Intuitive and very human friendly.