Queues // Laura's Static Site

[lmelgarejos]

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer	Instructor Response
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	No, I did not. I forgot.	This question was intended as a reminder that you should run the validator!
Why is it important to consider and use semantic HTML?	To target elements more easily.	Semantic HTML elements, like <article>, <header> or <nav>, can certainly be the target of a CSS selector, but that's not their main benefit. These elements serve two purposes: they make your HTML easier for other human programmers to read, and they provide structure needed for assistive technologies like screen readers.
How did you decide to structure your CSS?	I am not sure. I started from top to bottom following the HTML flow.
What was the most challenging piece of this assignment?	Positioning elements. I have not perfectly clear how the flow goes. Brosers are wierd.
Describe one area that you gained more clarity on when completing this assignment	Targeting elements.

[droberts-sea]

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	This is a good start, but I would still like to see more frequent, granular commits. Similar to how in Ruby we commit every time we get a method working, with HTML you should commit every time you build or change a section of your site.
Answered comprehension questions	See inline responses
Page fully loads	yes
No broken links (regular or images)	yes
Includes at least 4 pages and styling	yes
HTML
Uses the high-level tags for organization: header, footer, main	yes
Appropriately using semantic tags: section, article, etc.	yes
All images include alternate text	yes
CSS
Using class and ID names in style declarations	yes
Style declarations are DRY	Within each page they're DRY, but I see a lot of repeated styles across pages. A common strategy here is to have one stylesheet containing styles that apply to every page (for example to the header), and then separate files for page-specific stylings.
Overall

Great work overall! Site is attractive and easy to navigate, and HTML forms a clear tree structure. I especially like the way you've broken your CSS out into multiple files - that makes it easy to see what affects what.

[BrandiPhillips]

Good use of html tags!! It is clear what each one is doing and how you have divided up the different sections of your pages. Also, your css naming is clear and relevant. Nice work!! I see a lot of repeating of css. I wonder if there is a way to minimize that, DRY it up a bit? I wonder the same for the html, like the header and footer...

[BrandiPhillips]

One of the things I keep getting feed back on in my code at Zillow is being consistent with my use of white space. Here removing the white space after the h1 would make for neater code

[BrandiPhillips]

I noticed an empty 'p' tag above and assumed it was to create a visual separation. I am assuming its the same here. I am curious, is there a difference in the space provided by a 'section' vs a 'p'? If not, I would suggest being consistent with which one you use.

[BrandiPhillips]

I like the use of whitespace here to separate the footer section from the rest. I think it is good practice to have whitespace between different sections of code. :)

[BrandiPhillips]

This closing 'main' indent is a little off from the opening main and extra whitespace here.

[BrandiPhillips]

Again, consistent use of whitespace. Also, I would suggest using some comments to section off the css so it is clear what parts the different groups correspond to like "Header", "Main","Footer". Also, are the css groups ordered in the same order as the html that they correspond to?