Open
Conversation
…it to, will refactor in the morning
CheezItMan
reviewed
Jun 6, 2017
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad, just remember not to use raw jQuery in a view. Use this.$ instead to only select items within the view.
| import RolodexView from './views/rolodex_view.js'; | ||
|
|
||
| var application = new Application(); | ||
| $('#contact-details').hide(); |
There was a problem hiding this comment.
This should probably be in the document.ready handler.
| }, | ||
| contactDetails: function(contact) { | ||
| $('#contact-details').empty(); | ||
| $('#contact-details').show(); |
There was a problem hiding this comment.
I would suggest to show the modal after the contents are filled in to prevent a flash effect when the modal is shown, if the browser is busy.
Also don't use raw JavaScript to select items in the view. Use this.$ instead.
ROLODEXWhat We're Looking For
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROLODEX
Congratulations! You're submitting your assignment!
Comprehension Questions