Skip to content

Queues // Laura's rolodex#44

Open
lmelgarejos wants to merge 4 commits intoAda-C7:masterfrom
lmelgarejos:master
Open

Queues // Laura's rolodex#44
lmelgarejos wants to merge 4 commits intoAda-C7:masterfrom
lmelgarejos:master

Conversation

@lmelgarejos
Copy link
Copy Markdown

ROLODEX

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? The model in Backbone is the one that interacts with the data. Also in the model should go a big part of the logic that is relate with the data. Like validations, conversions and so on.
How do Backbone Views compare to Rails controllers? The views in Backbone are the charge of displaying the models, and it could be compared with the function that the controller has in Rails, since it is 'listening" for the events to happen, and manage them.
How do Backbone Events work in comparison to DOM events? DOM events wait for user's action, like click, press down a key... Backbone events could be set in the views and the functions associated to these events, can be call without any user intervention.
What do you think of Backbone in comparison to raw JavaScript & jQuery? Backbone organizes the code and separates from what backbone uses and what it is just raw JS, which makes the complete app easier to approach.
Do you have any recommendations on how we could improve this project for the next cohort? It was very confusing when we start replacing parts of the code with backbone. Perhaps a less complicated way to introduce backbone, and make sure that people have clear what it a framework is. It is not very clear for me yet.

@droberts-sea
Copy link
Copy Markdown

ROLODEX

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene I would like to see more frequent commits with more descriptive commit messages. If you're having trouble breaking out of the zone and remembering to commit, this article might be interesting.
Comprehension questions yes
Functionality
Created a Contact Model yes
Created a Rolodex Collection yes
Created a ContactView which renders an individual contact yes
ContactView responds to a click event when the user clicks on the contact yes
RolodexView created which renders the list of contacts yes
DOM Events handled for creating new Contacts yes
The RolodexView responds to custom Backbone event generated by ContactView to show the modal no - Currently, your ContactView.showDetails() method pops up the modal directly, even though the modal is under the RolodexView's element. While this certainly works, it makes your code more delicate and difficult to follow - imagine if instead of two types of views you had 10 or 15, all touching each others' elements. A cleaner way to approach it would be to trigger a custom Backbone event on the ContactView, and listen for that event from the RolodexView.
Styling, Foundation grid layout yes
All dynamic content is rendered using an Underscore template yes
Overall

Good work overall! Make sure to spend some time practicing with custom backbone events on the final VideoStore project (and feel free to come ask if they're still fuzzy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants