Skip to content

Janice's Yolodex#45

Open
janicewilson wants to merge 10 commits intoAda-C7:masterfrom
janicewilson:master
Open

Janice's Yolodex#45
janicewilson wants to merge 10 commits intoAda-C7:masterfrom
janicewilson:master

Conversation

@janicewilson
Copy link
Copy Markdown

ROLODEX

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? The model is a constructor that enables instances with the same validations, attributions and defaults (aka logic).
How do Backbone Views compare to Rails controllers? Whereas a specific url triggers a controller action in Rails, a defined event triggers an action in Backbone.
How do Backbone Events work in comparison to DOM events? Backbone Events can be bound to a specific view.
What do you think of Backbone in comparison to raw JavaScript & jQuery? Still confusing. But I'm muddling through.
Do you have any recommendations on how we could improve this project for the next cohort? I'd never thought I'd offer this, but ... pair program the hell out of it.

…nd function to contact_view to view the expanded details in the provided modal. I was also a bit lazy and simply toggled the clicked. But ... interviews. In a perfect world, I'd add a close button to the modal and enable clicking outside of modal to close such.
…rements require the close of the modal upon clicking anywhere outside of such. I time-boxed it. Still a WIP. I'll give it another go tomorrow.
@CheezItMan
Copy link
Copy Markdown

ROLODEX

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good # of commits
Comprehension questions Backbone Events can be listened to by any object, but are typically used for components to communicate changes. Otherwise good.
Functionality
Created a Contact Model Check
Created a Rolodex Collection Check
Created a ContactView which renders an individual contact Check
ContactView responds to a click event when the user clicks on the contact Check, although you have your ContactView using raw jQuery to modify an element outside of the view. It works, but isn't a best-practice as in Backbone views should only modify DOM elements within the view. A better method would be for the ContactView to trigger an event which the YolodexView would be listening to and that larger view which includes the modal could then render the appropriate content.
RolodexView created which renders the list of contacts YolodexView, lol!
DOM Events handled for creating new Contacts Check
The RolodexView responds to custom Backbone event generated by ContactView to show the modal As noted above the Rolodex doesn't respond to events from the Contactviews.
Styling, Foundation grid layout I like the enhanced styling
All dynamic content is rendered using an Underscore template Check
Overall Nice work overall, but you need to be careful to avoid raw jQuery in your Backbone Views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants