Skip to content

Queues // Laura's Trek#23

Open
lmelgarejos wants to merge 8 commits intoAda-C7:masterfrom
lmelgarejos:master
Open

Queues // Laura's Trek#23
lmelgarejos wants to merge 8 commits intoAda-C7:masterfrom
lmelgarejos:master

Conversation

@lmelgarejos
Copy link
Copy Markdown

@lmelgarejos lmelgarejos commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that some processes are executed independently of others. The program can run differently than the way we could expect to be the normal flow.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? successTripList function is being invoked in clickButtonHandler function. I do not have very clear how to structure JS in the conventional and functional way.
What kind of errors might the API give you? How did you choose to handle them? I chose to handle error with the .fail function to display on the page that something went wrong.
What is an Underscore template? Describe one template you used for this project. An underscore template is the view of our page that help us to keep our code organize and DRY. I defined the template for the list of trips from line 14 to 22 in the HTML. Then I compiled it in the JS document (line 4), and finally use it in the successTripList function.
Do you have any recommendations on how we could improve this project for the next cohort? None that I can think right now. :)

@PilgrimMemoirs
Copy link
Copy Markdown

PilgrimMemoirs commented Jun 1, 2017

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene ❗️ Commit more often, with more specific commit messages
Comprehension questions Well Done
Functionality
Click a button to list trips Well Done
Click a trip to see trip details Well Done
Fill out a form to reserve a spot Well Done - What other fields could be added?
Errors are reported to the user Mostly Good - handles for all trips, but not for if single trip show
Styling, Foundation grid layout ❗️Foundation Grid not used - other styling looks good. Foundation is linked.
Under the Hood
Trip data is retrieved using jQuery AJAX Well Done
JavaScript is well-organized and easy to read Well Done
HTML is semantic Well Done
All dynamic content is rendered using Underscore templates Well Done - it's cleaner to have the underscore templates not in the <head>, but towards the bottom of the document.
Overall
Great work with all requirements of the project. Submission meets expectations and the learn goals for this project. Be sure to continue practicing using Foundation Grid to structure your layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lmelgarejos @PilgrimMemoirs