Pipes - Irene - BackTREK

[idevera]

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What role does the Model play in Backbone?	The model is similar to models(classes) in Rails. The models validate data when inputs of a new instance is to be saved, it can create default values of instantiated object, and you can create custom methods for instantiated objects
How did the presence of Models and Collections change the way you thought about your app?	If your app will only be using collections, you can use collections to get data of a single object in your instantiated collection. Both Models and Collections allow us to interact with the requested API and use the data as objects within our application
How do Backbone Events compare to DOM events?	Backbone events listen to changes with Backbone Models and Collections ie. when a new Trip is created and the new trip needs to run an isValid method. This is different than DOM events where objects or elements are changed
How did you approach filtering? What was your data flow for this feature?	I filtered using HTML and javascript, not the backbone model
What do you think of Backbone in comparison to raw JavaScript & jQuery?	Allow us to separate our classes from most of our UI and Business logic
Do you have any recommendations on how we could improve this project for the next cohort?	Move filtering to being optional

[CheezItMan]

BackTREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Waaaay too few commits. Also put commit messages in describing functionality added not waves.
Comprehension questions	Check, model also handle communication with the API. Also Backbone events don't generally involve knowing when validation is supposed to be run, instead they are typically run when data in a model or collection changes. Note you can see an example of a filtered collection in the lecture material.
Organization
Models and collections are defined in separate files	Check
Code that relies on the DOM is located in or called by $(document).ready	Check
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)	Check, see an extremely minor note about where to add the update event listener.
Functionality
Display list of trips	Check
Display trip details	Check
Register for a trip	Check, but see my note about your code clearing form field values.
Add a trip	Check
Sort trips	Check
General
Snappy visual feedback for user actions	Minor styling note, trip names etc can overlap with other content on the displayed table.
API error handling	Check, well done.
Client-side validation	Check, see my notes for additional validations you could have written.
Overall	Small note, you've got an error in the console coming from foundation.js which you included via a tag in the html. See my notes on it. You hit the requirements with minor bugs. Nice work!

[CheezItMan]

Minor note: It's theoretically possible (1 in a trillion chance) that the fetch could finish and return before this line being executed. In which case renderList would not be executed. It's more proper to establish your listeners and then run fetch.

[CheezItMan]

By adding foundation here you're getting an error because jQuery isn't defined in global scope. to get rid of it you'd need to link in jQuery via a script tag, or use the foundation-sites npm package.

[CheezItMan]

You could also specify a urlRoot function.

urlRoot() {
  return `${this.baseURL}/${this.get('tripId')/+reservations`;
},

Note the string interpolation.

[CheezItMan]

Good, but I'd also suggest making sure the email has an @ in it.

[CheezItMan]

I would also check for a numeric value of weeks and cost and make sure they are non-negative.

[CheezItMan]

I suggest only clearing the input values on a successful save. Otherwise you're clearing the tripId and there's no way for a user to enter that.