Open
Conversation
BackTREKWhat We're Looking For
|
Hamled
reviewed
Dec 14, 2017
| const selectedTrip = tripList.findWhere({id: selectedId}); | ||
| console.log(url); | ||
| $('#trip-details').show(); | ||
| $.get(url, function(response) { |
There was a problem hiding this comment.
We should try to use Backbone's fetch function for models here instead of directly using jQuery's ajax functions.
| let tripInfoTemplate; | ||
| const render = function(tripList) { | ||
| console.log('in render'); | ||
| $('#trip-list').append('<tr><th>ID</th><th>CONTINENT</th><th>COST</th><th>CATEGORY</th></tr>'); |
There was a problem hiding this comment.
Before we start filling in the contents of the trip list we should clear it out by calling $('#trip-list').empty();.
This allows the render function to be idempotent, so that if our application has to call it multiple times (such as when adding or removing a trip), it will still do the correct thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BackTREK
Congratulations! You're submitting your assignment!
Comprehension Questions