Lauren Cardella -- Carets

[enigmagnetic]

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What role does the Model play in Backbone?	The Model plays largely the same role as models in Rails, that is, to hold data and business logic for related objects.
How did the presence of Models and Collections change the way you thought about your app?	I'm not sure that it did. Maybe because I thought of objects like Trips as being models before. It's definitely a clearer way of organizing the code according to the MVC convention.
How do Backbone Events compare to DOM events?	Backbone events are triggered by data changes and DOM events are triggered by user actions.
How did you approach filtering? What was your data flow for this feature?	I have not yet approached filtering but I will do so this week and resubmit.
What do you think of Backbone in comparison to raw JavaScript & jQuery?	It's nice to have some built-in methods that handle things like RESTful conventions and other convenient shorthand ways of doing things (i.e. forEach loops).
Do you have any recommendations on how we could improve this project for the next cohort?

[CheezItMan]

BackTREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	More granular commits would be better.
Comprehension questions	Check, backbone model also communicate with the API.
Organization
Models and collections are defined in separate files	Check
Code that relies on the DOM is located in or called by $(document).ready	Check
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)	Attempts are made, however addinga trip doesn't cause the tripList to refresh from the API.
Functionality
Display list of trips	Check
Display trip details	Check
Register for a trip	Check, but missing validations.
Add a trip	Check, but it's not adding the new trip to the list
Sort trips	It sorts, but subsequent clicks don't reverse the order.
General
Snappy visual feedback for user actions	nice animations for the register for a trip form. Good UI overall
API error handling	Reporting of errors to the user however the Add a trip errors are behind the modal and reporting of errors in registration simply say it failed, not why.
Client-side validation	Similar to API Errors, and the registering form performs no validations.
Overall	You hit most of the requirements, and it's a good start on the project, given your illness last week. Let me know if there are things you want me to look at in the future.

[CheezItMan]

This fetch will be run before the trip finishes saving and thus the new trip may not show up in the tripList.

[CheezItMan]

This is where you should have the tripList refresh, or fetch the trip's name and manually add it to the list.

[CheezItMan]

As I said earlier, you could also replace this url function with:

urlRoot: https://ada-backtrek-api.herokuapp.com/trips/

urlRoot is the endpoint that the API begins and Backbone can infer RESTful routes from there.

[CheezItMan]

You really should have some client-side validations, just if statements checking to make sure the form fields have valid values.

[CheezItMan]

What about if it's already sorted by this field? How could you then reverse the order?

[enigmagnetic]

Hi Chris,

I added filtering capabilities and made the suggested edits. The filtering doesn't quite work the way it should--if I sort a filtered list it removes the filtering and shows the entire list again.