Open
Conversation
Pipes - <Lindsey Deuel> - <Calculator>
| return do_math("/", numbers[0], numbers[1]) | ||
| elsif operation == "modulo" || operation == "%" | ||
| return do_math("%", numbers[0], numbers[1]) | ||
| end |
Collaborator
There was a problem hiding this comment.
If the user inputs a bogus operator, your program quits silently. Instead, it would be polite to let them know what went wrong.
| def do_math(operation,num1, num2) | ||
| if operation == "+" | ||
| puts "#{num1} + #{num2} = #{num1+num2}" | ||
| elsif operation == "-" |
Collaborator
There was a problem hiding this comment.
This big if statement looks very similar to the one in process_operator - would it be possible to consolidate the two?
|
|
||
| def get_number(operation) | ||
| begin | ||
| puts "What's your first number?" |
Collaborator
There was a problem hiding this comment.
I like making getting a number from the user its own method - good organization.
Collaborator
CalculatorWhat We're Looking For
Great work overall! |
VirtualLindsey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipes - -
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions