Open
Conversation
CalculatorWhat We're Looking For
|
tildeee
reviewed
Aug 14, 2017
| #note: this doesn't also check if it's a valid float :( | ||
| until value2 != 0 | ||
| puts "Please enter a valid value that isn't 0:" | ||
| value2 = gets.chomp.to_f |
There was a problem hiding this comment.
Just a small note... in this flow, your code doesn't check if the new number that replaces 0 in "divide" operations using your valid_float? method. It doesn't matter too much in the end because .to_f actually handles it pretty well, but I just wanted to let you know!
|
Great code! Your case statement is good! How you check for valid floats/input is also very interesting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions