Open
Conversation
With a bit more sleep and some nice insight from classmates today :)
CalculatorWhat We're Looking For
|
|
Let's loop back together soon, your code doesn't run for me |
Author
|
Sounds good. The first or second commit? I tried to edit the second one in place instead of fully copy and pasting all of the code, so if it's the second one, I very well might have missed somethings :/
…Sent from my iPhone
On Aug 14, 2017, at 08:03, dee ***@***.***> wrote:
Let's loop back together soon, your code doesn't run for me
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@vertige yup, your first commit runs. We'll look into a better way to submit code that may have helped with this (using git, lecture on Wednesday), but in general be careful about what you submit-- we'll only be checking the latest commit. |
Author
|
OK, I just check and my new one runs, so it was probably a copy/paste error
:/
Sorry! I know now. I thought, since the second commit was much later in the
day, it wouldn't count. Should I not resubmit later in a day (would that be
considered a late submission?) and just wait until after your feedback to
make updates for myself?
Thanks!
…On Mon, Aug 14, 2017 at 8:56 AM, dee ***@***.***> wrote:
@vertige <https://github.com/vertige> yup, your first commit runs. We'll
look into a better way to submit code that may have helped with this (using
git, lecture on Wednesday), but in general be careful about what you
submit-- we'll only be checking the latest commit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYhkAz17NYknc0h_uMmG1rj4VkBBj9dSks5sYG4jgaJpZM4O00rL>
.
|
|
We check pull requests before the deadline for submission, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions
user_input.to_f.to_s == user_input || user.to_i.to_s == user_input. I got tired. I also would have setup parentheticals along the lines of Option B in the comments on line 142