Create Pipes - <Roxanne Agerone> - <Calculator>#36
Open
RAgerone wants to merge 1 commit intoAda-C8:masterfrom
Open
Create Pipes - <Roxanne Agerone> - <Calculator>#36RAgerone wants to merge 1 commit intoAda-C8:masterfrom
RAgerone wants to merge 1 commit intoAda-C8:masterfrom
Conversation
| numbers = [] | ||
| puts "give me two numbers" | ||
| num = gets.chomp.to_f | ||
| numbers.push(num) |
Collaborator
There was a problem hiding this comment.
Watch your indentation here - lines 11 and 12 should be at the same level as line 10.
|
|
||
| def divide(a, b) | ||
| if b == 0 | ||
| puts "Dividing by zero is tricky! We will discuss this when we do calculus. |
Collaborator
There was a problem hiding this comment.
I like that you've split these out into separate methods! It may seem a little pedantic for things like + and -, but for something like division where you have an extra check to make it results in much cleaner code.
Collaborator
CalculatorWhat We're Looking For
Great work overall! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions