Skip to content

Create CanaanAndAmy#21

Open
canaanwest wants to merge 1 commit intoAda-C8:masterfrom
canaanwest:patch-1
Open

Create CanaanAndAmy#21
canaanwest wants to merge 1 commit intoAda-C8:masterfrom
canaanwest:patch-1

Conversation

@canaanwest
Copy link
Copy Markdown

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? We did a great job communicating, and towards the end of the project, we adjusted our driver/navigator responsibilities so that we ensured equality of positions.
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? Our show_display method was a great method within our Game class which we called anytime the user gave us a guess input. Each time this occurred, the show_display method was called to update the display, whether the answer was correct or incorrect. It doesn't take any inputs, but its outputs are the updating ASCII picture, the letters that the user attempted, and the updated blank spaces.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? when we first put the balnk spaces, we used a local variable instead of an instance variable. We chose to do this because we only needed this variable once, within the private function, and it was never called again outside of that function.
What code, if any, did you feel like you were duplicating more than necessary? For a while, we were duplicating the show_display function's functionality, but we ended up writing a function to feel this.
Is there a specific piece of code you'd like feedback on? We think the until loop starting at line 146 feels a little clunky. Thoughts?

@tildeee
Copy link
Copy Markdown

tildeee commented Aug 27, 2017

Word-Guess Game

What We're Looking For

Feature Feedback
Baseline
Regular Commits with meaningful commit messages. I only see one commit!
Readable code with consistent indentation. x
Answered comprehension questions x
Product Functionalities
Created a Class to encapsulate game functionality. x
Used methods to DRY up your code. x
Created instance variables & local variables where appropriate. x
Used Arrays to store lists of letters guessed. x
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. x
Programmed "defensively" to detect errors in user input. x

Comment thread CanaanAndAmy
puts "\e[H\e[2J"
end

puts "\u{1F438} \u{1F438} \u{1F438} Thanks for playing our word game! \u{1F438} \u{1F438} \u{1F438}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice emoji!

Comment thread CanaanAndAmy
attr_reader :ASCII_init, :displayed
def initialize
@ASCII_init = [" @ . . @".green, " ( --- )".green, " ( >__< )".green, " ^^ ~~ ^^".green, " ~~~~~~~~~~~".green, " ~~~~~~~~~".green]
@displayed = display_picture(@ASCII_init)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not necessary to make @displayed = display_picture() and just call .display_picture() instead of .displayed on line 41

@tildeee
Copy link
Copy Markdown

tildeee commented Aug 28, 2017

Great game! Good code, and good execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants