Ada Trader - Marisa Morris

[marisamorris]

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How do Backbone Views help structure your code?	Backbone views help structure the code in that they hold all the logic similar to rails controllers.
Did you use jQuery directly in your Views? How, and why?	Yes but i'm not sure i was supposed without the $el.
What was an example of an event you triggered? Why did you need to trigger it?	showTrade was an event that I triggered.
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different?	Its different in that Jasmine tests run without support from the browser.

[CheezItMan]

Ada Trader

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Not very many commits, good commit mesages
Comprehension questions	Check, You actually didn't use jQuery directly, instead you used this.$. Also in our tests both Jasmine and Minitest don't need the support of the browser. However if you wanted to test the views etc, you would need some way to mock the DOM.
Organization
Models and collections are defined in separate files	Check
Code that relies on the DOM is located in or called by $(document).ready	Check
Functionality
Quote prices change when clicking Buy and Sell	Check
The Trade History updates when buying and selling a quote	Check
A user can create an open order using the Order Entry Form	Check
An open order removes itself from the open orders and updates the Trade History when fulfilled	MISSING you need the Order instances listening for changes in the Quote, see my in-code notes. You had most of what you needed, only lacking a listenTo and event handlers to respond to the event.
General
Has separate views for different parts of the app	Check
Uses events (listening/handling and triggering) to manage different behavior in views	You have event listing to respond to changes in Quotes, and respond to events in Order, Quote and the forms.
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render)	You avoided using jQuery directly. I would use the syntax like initialize(params) { as opposed to initialize: function(params), but that's a minor issue. Another minor thing is to prefer use of single quotes over double quotes.
Error handling for the Order Entry Form	Well done using validate in the form!
Testing
Has unit tests for models	MISING
Overall	It looks like you got part of the way through the project but ran into trouble getting the different components to talk to each other. Hopefully my notes give you some ideas what you could have done. You did well setting up views and rendering content, but had trouble extending further than our livecode.

[CheezItMan]

Since you're passing a Quote instance to the Order, you could listen for price changes,

Something like

initialize(params) {
  this.listenTo(this.get('quote'), 'change', (quote) => {
    // code to buy a quote, maybe a trigger to alert the view or quote.
  }
},

[CheezItMan]

I'm not sure what this accomplishes, quotes just represent the current price of a quote, why would there be a buy attribute?

[CheezItMan]

Could you merge addBuyOrder and sellBuyOrder?