Skip to content

Created Pull Request Template #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CheezItMan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Created Pull Request Template #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb81ea3
Created Pull Request Template
CheezItMan Jan 21, 2017
1665c6a
Responding to Kari's input
CheezItMan Jan 23, 2017
5bb73ba
A bit of direction at the top
CheezItMan Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# Mood Analysis
Congratulations! You're submitting your assignment. Before submitting your updated Ruby Code please answer the questions below from the README.

### What's Happening?
Explain what is happening on each of the following lines in the code.

| Line # | What's happening?
|:------:|-------------------
| 1 |
| 2 |
| 3 |
| 6 |
| 7-8 |
| 9 |
| 10 |
| 11 |
| 12 |
| 13 |
| 14 |
| 18-24 |

### Data Types
What's the Data Type of the following?

| Code | Data Type
|----------------------------|-----------
| FEELINGS |
| :sad |
| happy |
| words |
| words.split(" ") |
| FEELINGS[:sad] |
| FEELINGS[:happy].include? |
| analyze_mood(text) |

### Explaining the Code
| Question | Answer
|------------------------|-------
| Why do we need line 9? |
| What is the relationship between `words` and `word` (line 10)? |
| Why doesn't line 22 have an associated if/condition? |
| What is the relationship between `text[0]`, `text[1]`, and `words`? |


## Comprehension Questions
Copy link
Copy Markdown
Contributor

@kariabancroft kariabancroft Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question that I have on this assignment is that is also comes along with those comprehension questions in the original assignment. Should we move them into here to consolidate the comprehension?




| Question | Answer |
|--- |--- |
| Why does 03/13 come out as neutral when it should be happy? How could we fix this? | |
| Where should we call strip_punctuation? Does it matter? Why? | |
| What are you going to do if there aren't at least 3 happy days? Where do you need to handle that case? | |
| In the `overall_mood` function would it make more sense to use an Array or a Hash to determine the most common mood? Why? | |
| What if we eventually want to add feelings to our analysis? For example if we wanted to add 'angry' or 'excited' to the list of feelings in the analysis? Can we write this code in a way that will prevent us from having to re-write it later? |