fix: review usability and apply improvements#125
Merged
Conversation
- Wire up DeleteConfirmationDialog in TaskItem so deletes require explicit confirmation instead of firing immediately - Add aria-label to TaskItem delete/edit buttons for screen readers - Replace browser alert() in TaskEditDialog with a destructive toast notification so validation errors don't interrupt workflow - Add isSaving loading state to CategoryManagement that disables buttons and shows progress text during forceSyncToDatabase() - Show success toasts after category add/update/delete operations - Use Alert variant="destructive" for auth errors and distinct green styling for auth success messages https://claude.ai/code/session_01WXAUpbzPAbGBi4bv6gxz4w
- Replace raw <input> with shadcn Input component in NewTaskForm so styling is consistent with the rest of the UI - Add proper Label and aria-required/aria-invalid/aria-describedby to title field; show inline error message on blur or failed submit - Add visible labels to category and project selects in NewTaskForm - Replace text-gray-500 with text-muted-foreground in project client select item for theme compliance - Add success toasts to ProjectManagement after add/update/delete/reset - Show descriptive empty state with icon and helper copy on TaskList when a work day is active but no tasks have been added yet - Improve Index.tsx "no tasks" copy to direct users to the Tasks page https://claude.ai/code/session_01WXAUpbzPAbGBi4bv6gxz4w
- Expand TaskItem delete/edit buttons to min-h-[44px] min-w-[44px] so they meet WCAG 2.1 AA touch-target size requirements on mobile - Replace all hardcoded text-gray-* classes with Tailwind theme variables (text-foreground, text-muted-foreground) across TaskItem, TaskEditDialog, CategoryManagement, ProjectManagement, Navigation, DaySummary, and SyncStatus to honour the project's color system and improve contrast in dark/light modes - Replace bg-gray-100/text-gray-800 non-billable badge with bg-muted/text-muted-foreground in CategoryManagement - Add aria-live="polite" aria-atomic="true" to the task count heading in TaskList so screen readers announce list changes https://claude.ai/code/session_01WXAUpbzPAbGBi4bv6gxz4w
- Add aria-required="true" to required inputs in TaskEditDialog, CategoryManagement, and ProjectManagement for screen-reader clarity - Switch required-field asterisk from text-red-700 to text-destructive so it respects the theme's semantic color token - Add visible "Markdown supported" hint label to the description field in NewTaskForm so users know formatting is available - Add "(supports Markdown)" sub-label to description in TaskEditDialog - Fix NotFound page to use bg-background/text-muted-foreground/text-primary instead of hardcoded gray/blue colors - Fix remaining text-gray-600 in ExportDialog import drop zone https://claude.ai/code/session_01WXAUpbzPAbGBi4bv6gxz4w
The workflow previously only triggered on pushes to main/master and PRs targeting those branches. This meant feature branches received no CI feedback until a PR was opened, and the test suite never ran on `push` events for branches like `claude/*`. - Broaden the push trigger to `branches: ["**"]` so every branch push runs lint, tests, and both builds - Add `workflow_dispatch` so maintainers can manually trigger the workflow at any time without needing a new commit https://claude.ai/code/session_01WXAUpbzPAbGBi4bv6gxz4w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usability improvements to meet WCAG specifications.
Type of Change
Related Issue
Closes #
Changes Made
Checklist
Documentation
README.mdCHANGELOG.mdupdated accordinglyGeneral
mainnpm run test,npm run lint, andnpm run buildNotes for Reviewers