fix: replace mobile bottom-sheet usage with modals#144
Merged
Conversation
AdamJ
changed the title
AdaptiveDialog now always renders a Radix Dialog (modal) regardless of screen size, removing the vaul Drawer/bottom-sheet path entirely. snapPoints prop is kept in the interface for backwards compatibility but has no effect. https://claude.ai/code/session_013W4Gzgv5HdUtV71io2xdBi
AdamJ
force-pushed
the
claude/ios-sheet-modal-migration-UfI7R
branch
from
382d5d8 to
2e9bf58
Compare
Deploying timetrackerpro with
|
| Latest commit: |
2e9bf58
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6cb64f58.timetrackerpro.pages.dev |
| Branch Preview URL: | https://claude-ios-sheet-modal-migra.timetrackerpro.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the mobile bottom-sheet (vaul Drawer) behavior from
AdaptiveDialog. All dialogs now render as standard Radix modals on every screen size, including mobile.Type of Change
Related Issue
Closes #
Changes Made
src/components/ui/adaptive-dialog.tsx— removeduseIsMobilehook, allDrawerimports, and the mobile branch. EveryAdaptive*export now delegates directly to the correspondingDialog*component. ThesnapPointsprop is retained in the interface for API compatibility but has no effect.Checklist
Documentation
README.mdCHANGELOG.mdupdated accordinglyGeneral
mainnpm run test,npm run lint, andnpm run buildNotes for Reviewers
The six dialogs that use
AdaptiveDialog(TaskEditDialog,StartDayDialog,ArchiveEditDialog,DeleteConfirmationDialog,StaleDayDialog,PlannedTaskDialog) require no changes — they consume the same exported API and will automatically get modal behavior.