Add Docker-based bit-compare CI workflow#1
Closed
Adehill wants to merge 7 commits into
Closed
Conversation
Introduce three new automation entry points for OpenIFS, plus a shared helper library: - scripts/bootstrap/docker/ — container-based OpenIFS install: builds the toolchain image (apt + OpenMPI), clones or copies the source, and runs the test suite end-to-end. Replaces the legacy scripts/docker/ - scripts/ci/docker_ci/ — branch-vs-branch SAVED_NORMS bit-compare driver: builds a control branch and a test branch in matching images, runs openifs-test.sh -cbt, and writes a self-contained text report - scripts/shared/ — shared library used by both drivers (shared_helpers, docker_lib, ci_lib, read_yml_config, setup_logging, find_py_packages) - .github/workflows/bit-compare-docker.yml — GitHub Actions workflow that drives the docker_ci bit-compare on push/PR Removes the legacy scripts/docker/ tree (superseded by bootstrap/docker) and updates README.md, .gitignore, and oifs-config.edit_me.sh to point at the new paths.
The workflow and the two YAML defaults all hardcoded the personal
fork `Adehill/openifs.git`, which would break the workflow when run
in any other repo and present a confusing default to anyone running
the bootstrap script locally.
- .github/workflows/bit-compare-docker.yml: replace the hardcoded
URL in `Resolve control SHA` and in the rendered `ci_test_docker.yml`
with `${{ github.repository }}`, so the workflow follows whichever
fork it lives in (Adehill/openifs for testing,
ecmwf-ifs/openifs upstream)
- scripts/bootstrap/docker/config/create_openifs_docker.yml: default
`openifs_repo_url` to `https://github.com/ecmwf-ifs/openifs.git`
- scripts/ci/docker_ci/config/ci_test_docker.yml: same default change
(this file is only read for local script runs — the GitHub Actions
workflow renders its own copy in /tmp)
…are not changed in the CI
Find the cycle version in bundle.yml so the workflow no hardcoded 48r1, then use the matching openifs-lts/CY* branch as the push control (falling back to main if it does not yet exist), and skip direct pushes to LTS branches since changes land there via PR. Important to note this needs to be updated to allow unsupported branches, when they are defined
Narrow the push trigger to main so feature-branch pushes no longer
double-trigger alongside their pull request, and pass the PR base ref
through a typed env: block rather than ${{ }} interpolation inside the
run script to remove a shell-injection sink.
Move WORK_DIR out of github.workspace in the CI workflow so the test phase no longer copies the workspace into a subdirectory of itself, and add _oifs_docker_ci to populate_from_local's ignore patterns so the helper is safe against the same nested layout elsewhere. This better replicates the local docker_ci workflow, while preventing a fail on the github action CI workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan