Security: Prototype Pollution via Object.assign in mergeServicesData#830
Open
tomaioo wants to merge 1 commit into
Open
Security: Prototype Pollution via Object.assign in mergeServicesData#830tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
The `mergeServicesData` function uses spread and `reduce` to merge arrays into an object keyed by `id`. If an attacker can control the `id` property of a service, they can set it to `__proto__`, `constructor`, or `prototype`, causing prototype pollution when the object is later used. Although `Object.values` is used, the polluted object can still affect subsequent operations if properties are accessed directly. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Prototype Pollution via Object.assign in mergeServicesData
Problem
Severity:
High| File:scripts/services/merge-services-data.js:L17The
mergeServicesDatafunction uses spread andreduceto merge arrays into an object keyed byid. If an attacker can control theidproperty of a service, they can set it to__proto__,constructor, orprototype, causing prototype pollution when the object is later used. AlthoughObject.valuesis used, the polluted object can still affect subsequent operations if properties are accessed directly.Solution
Use
Object.create(null)to create a prototype-less object, or validate/sanitize theidfield before using it as a key. Alternatively, use a Map instead of a plain object.Changes
scripts/services/merge-services-data.js(modified)