Refactor: Centralized API Architecture & HTML5 Form Validation (#35, #36)#42
Open
Debangana-Dutta wants to merge 1 commit into
Open
Refactor: Centralized API Architecture & HTML5 Form Validation (#35, #36)#42Debangana-Dutta wants to merge 1 commit into
Debangana-Dutta wants to merge 1 commit into
Conversation
Debangana-Dutta
changed the title
Author
|
Hi , @AditixAnand i have implemented a centralized API configuration (#35) and added form validation (#36). I've updated all relevant modules (Chatbot, Admin, Auth) to follow this new architecture. I would appreciate it if you could review this for an Advanced label. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses the issue where login and registration forms allowed empty submissions, potentially leading to unnecessary backend errors.
Changes made:
Added the required attribute to all input fields in login.html and register.html.
Ensured the email input field uses type="email" to provide immediate client-side validation and a better user experience.
Integrated a centralized API configuration via scripts/api_config.js to standardize backend communication across the authentication module.
Related Issues: > Fixes #35, Fixes #36