fix(scriptmsg): prevent non-string payloads from reaching split()#96
Open
Antiwarden wants to merge 1 commit into
Open
fix(scriptmsg): prevent non-string payloads from reaching split()#96Antiwarden wants to merge 1 commit into
Antiwarden wants to merge 1 commit into
Conversation
Prevent the scriptmsg handler from receiving non-string payloads that would cause message parsing to fail near the end of a run. While the issue didn't seem system-critical, the resulting crash in OverlayThread.js may have interrupted the initialization of other scripts. After this fix, the previously observed "reference to undefined property this.totalExp[level]" warning pointing to Misc.js no longer occurs, suggesting it may have been a secondary effect of the script failure.
Author
|
Please ignore the assumption about the cause for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the scriptmsg handler from receiving non-string payloads that would cause message parsing to fail near the end of a run.